Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next v8 - Filters #400

Merged
merged 79 commits into from
Jan 19, 2024
Merged

Next v8 - Filters #400

merged 79 commits into from
Jan 19, 2024

Conversation

bbazukun123
Copy link
Collaborator

@bbazukun123 bbazukun123 commented Jan 5, 2024

  • Up-version all filters to be v8.0.0 and use latest pixi v8 dependencies (including RCs)
  • TODOs / Known Issues:
    • WebGPU vec3 uniform not inferring the value from pixi Color object correctly. Once fix, these filters need to be verified
      - Color Replace
      - Glow
      - Simple Lightmap
      - Outline
      - + a few others that has single color options
      - UPDATE: Reverted back to use Float32Array for vec3 colors as changing pixi color does not reflect the value changes correctly on the uniforms.
    • Color Gradient: Restructure array uniforms for WebGPU
    • Color Map: 'nearest' does nothing on WebGPU
    • Glitch: Update WGSL
    • Displacement filter issue

@bigtimebuddy
Copy link
Member

In v8 we are moving Pixi to be a single package with sub package exports. I wonder if we should do the same thing with filters. Would eliminate having to manage and publish multiple packages.

@bbazukun123
Copy link
Collaborator Author

In v8 we are moving Pixi to be a single package with sub package exports. I wonder if we should do the same thing with filters. Would eliminate having to manage and publish multiple packages.

Thanks for the raise @bigtimebuddy ! @Zyie has noted and created a ticket for this: https://github.com/orgs/pixijs/projects/2/views/4?pane=issue&itemId=49264154

@bbazukun123 bbazukun123 marked this pull request as ready for review January 8, 2024 14:50
@bigtimebuddy bigtimebuddy merged commit 98a3343 into next-v8-base Jan 19, 2024
2 checks passed
@bigtimebuddy bigtimebuddy deleted the next-v8-webgl branch January 19, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants